kaxil opened a new pull request #15395:
URL: https://github.com/apache/airflow/pull/15395


   This bug got introduced in #14909.
   
   The following DAG errors with: `TypeError: '<' not supported between 
instances of 'dict' and 'dict'`
   
   ```python
   from airflow import models
   from airflow.operators.dummy import DummyOperator
   from datetime import datetime, timedelta
   params = {
       "staging_schema": [{"key:":"foo","value":"bar"},
                          {"key:":"this","value":"that"}]
   }
   
   with models.DAG(dag_id='test-dag',
                   start_date=datetime(2019, 2, 14),
                   schedule_interval='30 13 * * *',
                   catchup=False,
                   max_active_runs=1,
                   params=params
                   ) as dag:
       my_task = DummyOperator(
           task_id='task1'
       )
   ```
   
   Full Error:
   
   ```
     File 
"/usr/local/lib/python3.7/site-packages/airflow/serialization/serialized_objects.py",
 line 210, in <dictcomp>
       return cls._encode({str(k): cls._serialize(v) for k, v in var.items()}, 
type_=DAT.DICT)
     File 
"/usr/local/lib/python3.7/site-packages/airflow/serialization/serialized_objects.py",
 line 212, in _serialize
       return sorted(cls._serialize(v) for v in var)
   TypeError: '<' not supported between instances of 'dict' and 'dict'
   During handling of the above exception, another exception occurred:
   ...
   ```
   
   This is because `sorted()` does not work with dict as it can't compare.
   It also fails when we have list/set/dict with multiple types
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to