mik-laj commented on a change in pull request #15425:
URL: https://github.com/apache/airflow/pull/15425#discussion_r616005330
##########
File path: airflow/cli/commands/connection_command.py
##########
@@ -29,7 +29,7 @@
from airflow.exceptions import AirflowNotFoundException
from airflow.hooks.base import BaseHook
from airflow.models import Connection
-from airflow.secrets.local_filesystem import _create_connection,
load_connections_dict
+from airflow.secrets.local_filesystem import load_connections_dict
Review comment:
Yes. We should avoid dependency on secrets. We already have a lot of
recursive imports between various connection modules, secret and others, so
creating new modules will cure those situations a bit.
> move all these helper functions outside of secrets/local_filesystem.py
I think it is the best solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
