[GitHub] [airflow] uranusjr commented on a change in pull request #15382: Fix dag.clear() to set multiple dags to running when necessary

Tue, 20 Apr 2021 12:08:52 -0700 


uranusjr commented on a change in pull request #15382:
URL: https://github.com/apache/airflow/pull/15382#discussion_r616963403



##########
File path: airflow/models/taskinstance.py
##########
@@ -205,19 +206,25 @@ def clear_task_instances(
         for job in 
session.query(BaseJob).filter(BaseJob.id.in_(job_ids)).all():  # noqa
             job.state = State.SHUTDOWN
 
-    if activate_dag_runs and tis:
+    if (dag_run_state is not False) and tis:

Review comment:
       ```suggestion
       if dag_run_state is not False and tis:
   ```
   
   I don’t think parantheses are needed here? If this feels ambiguous, maybe 
swap them?
   
   ```python
       if tis and dag_run_state is not False:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to