kaxil opened a new pull request #15477:
URL: https://github.com/apache/airflow/pull/15477


   We create a Statefulset if persistence is enabled and Deployment
   otherwise. Upgrading strategies are different for both those types
   of resources.
   
   Statefulst needs `updateStrategy`, deployment needs `strategy`.
   
   Without this fix, using Helm Chart with CeleryExecutor failed with
   
   ```
   helm install airflow -n airflow --set executor=CeleryExecutor --set 
images.airflow.repository=k8s-dags --set images.airflow.tag=1.0.2 .
   Error: unable to build kubernetes objects from release manifest: error 
validating "": error validating data: ValidationError(StatefulSet.spec): 
unknown field "strategy" in io.k8s.api.apps.v1.StatefulSetSpec
   ```
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to