ephraimbuddy commented on a change in pull request #15042:
URL: https://github.com/apache/airflow/pull/15042#discussion_r617268502
##########
File path: airflow/www/security.py
##########
@@ -18,16 +18,23 @@
#
import warnings
+from datetime import timedelta
from typing import Dict, Optional, Sequence, Set, Tuple
-from flask import current_app, g
+import jwt
+from flask import current_app, g, request
+from flask_appbuilder.const import AUTH_DB, AUTH_LDAP, AUTH_OAUTH,
AUTH_REMOTE_USER
from flask_appbuilder.security.sqla import models as sqla_models
from flask_appbuilder.security.sqla.manager import SecurityManager
from flask_appbuilder.security.sqla.models import PermissionView, Role, User
+from flask_jwt_extended import JWTManager, create_access_token,
create_refresh_token
+from flask_login import login_user
from sqlalchemy import or_
from sqlalchemy.orm import joinedload
from airflow import models
+from airflow.api_connexion.exceptions import Unauthenticated
+from airflow.api_connexion.schemas.auth_schema import auth_schema
Review comment:
> Agree. This was why I kept them at api_connexion/endpoints/ until this
commit
[724c909](https://github.com/apache/airflow/commit/724c90939e3be8dccaaea9a5c92582397d26ac81)
>
> Moving it will mean that some other codes would be moved. That's actually
how flask appbuilder handled the views
https://github.com/dpgaspar/Flask-AppBuilder/blob/27b15e59316e85e0fe62b8aa9978391ed4c729c9/flask_appbuilder/security/views.py#L624
>
> Happy to move it back if you accept @ashb
Taking back this statement and working on a way around it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
