ashb commented on a change in pull request #15474:
URL: https://github.com/apache/airflow/pull/15474#discussion_r619299250
##########
File path: airflow/www/views.py
##########
@@ -2036,12 +1996,55 @@ def recurse_nodes(task, visited):
node['extra_links'] = task.extra_links
return node
- data = {
+ return {
'name': '[DAG]',
'children': [recurse_nodes(t, set()) for t in dag.roots],
'instances': [dag_runs.get(d) or {'execution_date': d.isoformat()}
for d in dates],
}
+ @expose('/tree')
+ @auth.has_access(
+ [
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAG),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_TASK_INSTANCE),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_TASK_LOG),
+ ]
+ )
+ @gzipped # pylint: disable=too-many-locals
+ @action_logging # pylint: disable=too-many-locals
+ def tree(self):
+ """Get Dag as tree."""
+ dag_id = request.args.get('dag_id')
+ dag = current_app.dag_bag.get_dag(dag_id)
+ if not dag:
+ flash(f'DAG "{dag_id}" seems to be missing from DagBag.', "error")
+ return redirect(url_for('Airflow.index'))
+
+ root = request.args.get('root')
+ if root:
+ dag = dag.sub_dag(task_ids_or_regex=root,
include_downstream=False, include_upstream=True)
+
+ num_runs = request.args.get('num_runs', type=int)
+ if num_runs is None:
+ num_runs = conf.getint('webserver',
'default_dag_run_display_number')
+
+ try:
+ base_date = timezone.parse(request.args["base_date"])
+ except (KeyError, ValueError):
+ base_date = dag.get_latest_execution_date() or timezone.utcnow()
+
+ with create_session() as session:
+ dag_runs = (
+ session.query(DagRun)
+ .filter(DagRun.dag_id == dag.dag_id, DagRun.execution_date <=
base_date)
+ .order_by(DagRun.execution_date.desc())
+ .limit(num_runs)
+ .all()
+ )
+ dag_runs = {dr.execution_date: alchemy_to_dict(dr) for dr in dag_runs}
+
+ max_date = max(dag_runs, default=None)
Review comment:
(I thought this was a bug, but it turns out if you max/min/sorted on a
dict it operates over the keys.
For clarity lets make this change though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
