potiuk commented on issue #15463:
URL: https://github.com/apache/airflow/issues/15463#issuecomment-826262336


   > lol, this culprit hides 
[deep](https://github.com/apache/beam/blob/4202efb5f01254e46fe421225a2ebbdba46da04d/sdks/python/setup.py#L192)
   
   It does. But with even more extras I think I managed to eat cake and have it 
too..
   
   The nice thing is that I am not impairing the whole "google" provider, or 
"apache.beam" provider for Airflow. They will install ok alongside each other 
and most of it will even work even if the 'gcp' extra from Bem is not installed 
(most of the functionality will work with the new google python packages, but 
not everything). But even if someone wants to have "conflicting" installation 
with old PIP, they will be able to:
   
   The "google" provider has an optional extra for beam already which I 
modified (we generate them automatically):
   
   ```
           extras_require={
               'amazon': ['apache-airflow-providers-amazon'],
               'apache.beam': ['apache-airflow-providers-apache-beam', 
'apache-beam[gcp]'],
               'apache.cassandra': 
['apache-airflow-providers-apache-cassandra'],
               ....
           },
   ```
   
   And likewise "apache.beam" provider:
   
   ```
           extras_require={'google': ['apache-airflow-providers-google', 
'apache-beam[gcp]']},
   ```
   
   So if someone really wants to install all the mess with old PIP the will be 
able to do `pip install apache-airflow-providers-google['apache.beam']` or `pip 
install apache-airflow-providers-apache-beam['google']` and it will work (or 
not (?)) in exactly the same way it worked (or not (?)) before.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to