[jira] [Commented] (AIRFLOW-4267) Fix Task Instance duration in Graph View in Fab-Based UI

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/AIRFLOW-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813817#comment-16813817
 ] 

ASF GitHub Bot commented on AIRFLOW-4267:
-----------------------------------------

kaxil commented on pull request #5071: [AIRFLOW-4267] Fix TI duration in Graph 
View
URL: https://github.com/apache/airflow/pull/5071
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4267
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   The duration field is missing in the Graph View for the Fab-based RBAC UI.
   This is because of the bug in the code. Instead of task.duration it should 
be ti.duration.
   The duration is associated with a Task Instance and no a Task.
   
   **Before**:
   <img width="469" alt="missing-duration" 
src="https://user-images.githubusercontent.com/8811558/55835491-33eaa500-5b14-11e9-9425-ee10b30cca38.png";>
   
   **After the Fix**
   <img width="451" alt="after-fix" 
src="https://user-images.githubusercontent.com/8811558/55835518-41079400-5b14-11e9-8c7e-e8208d94ee4f.png";>
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   n/a for JS code
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix Task Instance duration in Graph View in Fab-Based UI
> --------------------------------------------------------
>
>                 Key: AIRFLOW-4267
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4267
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.2, 1.10.3
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Critical
>         Attachments: Screenshot 2019-04-09 at 21.58.54.png, Screenshot 
> 2019-04-09 at 22.01.42.png
>
>
> The duration field is missing in the Graph View for the Fab-based RBAC UI.
> This is because of the bug in the code. Instead of *task.duration* it should 
> be *ti.duration*.
> The duration is associated with a *Task Instance* and no a *Task*.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)