feluelle commented on a change in pull request #5070: [AIRFLOW-XXX] Add a git pre-commit hook template URL: https://github.com/apache/airflow/pull/5070#discussion_r273808936
########## File path: .githooks/pre-commit ########## @@ -0,0 +1,74 @@ +#!/bin/sh + +# This Git Hook is based on the .travis.yml to avoid as many errors in the Travis CI Pipeline as possible. +# It is optional, but recommended to have at least the pre-tests section enabled. + +# Please make sure that you have your development environment setup and ready. See the CONTRIBUTING.md for more information. + +# NOTE: You need to set the following variables before running this hook. +# A python virtual environment is needed for the pre-tests to run in. +VIRTUAL_ENV_PATH=/Users/feluelle/venv/apache-airflow/bin/activate Review comment: ..or probably better to define them not in the script directly and instead `export` these variables before running the script. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
