ginevragaudioso edited a comment on pull request #15210:
URL: https://github.com/apache/airflow/pull/15210#issuecomment-827704730


   > The tests need expanding -- the TIs it create have the same priority and 
execution_date, so we aren't actually asserting that the TIs are sorted 
correctly.
   
   The TIs created do not have the same execution date, unless I am missing 
something.
   ```
           dr1 = dag_1.create_dagrun(
                run_type=DagRunType.SCHEDULED,
                execution_date=DEFAULT_DATE + timedelta(hours=1),
                state=State.RUNNING,
            )
            dr2 = dag_2.create_dagrun(
                run_type=DagRunType.SCHEDULED,
                execution_date=DEFAULT_DATE,
                state=State.RUNNING,
            )
   ```
   So the test is testing that we pick the one with the earliest execution date 
even if it is alphabetically later (which is exactly the bug being fixed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to