dstandish edited a comment on pull request #15285:
URL: https://github.com/apache/airflow/pull/15285#issuecomment-827900483


   > I'm just trying to see if this will even work type-wise  
   
   Totally makes sense :) 
   
   > I'd rather we call it TaskInstanceState honestly
   
   Let me offer an argument for _not_ this.
   
   It's possible to use xcom as a store of task instance state, because it is 
at the grain of task instance (task + execution date).
   
   So we can imagine that XCom could have reasonably been called 
TaskInstanceState.
   
   What this enum represents is something very different.  It's the 
TaskInstance's _execution_ state -- not a way of storing state data for a task 
instance.
   
   That's why I like the idea of adding the word `execution` or `run`. 
   
   Separately, I think we could justify going without the word _instance_ 
because this enum represents possible values for task execution states in the 
abstract, and it is maybe irrelevant that the when a task gets combined with an 
execution date it is called a task instance.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to