uranusjr commented on a change in pull request #15397:
URL: https://github.com/apache/airflow/pull/15397#discussion_r621908439
##########
File path: airflow/models/dag.py
##########
@@ -533,94 +537,53 @@ def next_dagrun_info(
"automated" DagRuns for this dag (scheduled or backfill, but not
manual)
"""
- if (
- self.schedule_interval == "@once" and date_last_automated_dagrun
- ) or self.schedule_interval is None:
- # Manual trigger, or already created the run for @once, can short
circuit
+ # XXX: The timezone.coerce_datetime calls in this function should not
Review comment:
It means something along the lines of “I don’t like this but there’s no
better way to do it now without digging deep into the rabbit hole and add a
bunch of unrelated diffs to this PR, this should be refactored away”. I see
other projects use markers like `TODO` or `FIXME` for this as well.
https://www.snellman.net/blog/archive/2017-04-17-xxx-fixme/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
