[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiaodong DENG updated AIRFLOW-4269: ----------------------------------- Description: Issue-1: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break. When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing. We should use a "break" here. Issue-2: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L921] *"if len(active_dag_runs) >= dag.max_active_runs:"* should be "*if len(active_dag_runs) > dag.max_active_runs:".* was: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break. When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing. We should use a "break" here. > Minor refactoring on jobs._process_task_instances() > --------------------------------------------------- > > Key: AIRFLOW-4269 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4269 > Project: Apache Airflow > Issue Type: Improvement > Affects Versions: 1.10.2 > Reporter: Xiaodong DENG > Assignee: Xiaodong DENG > Priority: Minor > > Issue-1: > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] > is a "continue" while it should be a break. > When *len(active_dag_runs) >= dag.max_active_runs* , the following part of > the for-loop will give the same result and result in a "continue" again and > again, doing nothing. > We should use a "break" here. > > Issue-2: > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L921] > *"if len(active_dag_runs) >= dag.max_active_runs:"* should be "*if > len(active_dag_runs) > dag.max_active_runs:".* -- This message was sent by Atlassian JIRA (v7.6.3#76005)