DerekHeldtWerle commented on a change in pull request #14152:
URL: https://github.com/apache/airflow/pull/14152#discussion_r624194368
##########
File path: chart/tests/test_basic_helm_chart.py
##########
@@ -36,13 +36,19 @@ def test_basic_deployments(self):
'metadata': 'AA',
},
'labels': {"TEST-LABEL": "TEST-VALUE"},
+ "fullnameOverride": "TEST-BASIC",
Review comment:
It is not a hard requirement, just allows for every service account to
"match" the exact form of the other items in the `list_of_kind_names_tuples`.
Without it set, each service account would change to
`TEST-BASIC-airflow-<service>` based on how the [templating of the
accounts](https://github.com/apache/airflow/pull/14152/files#diff-dc12e5cc8016c85ad9e662af7c8b8cfb49d91965225e94aa12146dc1f371fc86R421)
is setup. I'm totally fine with removing it and changing the tuple entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
