kaxil commented on a change in pull request #14152:
URL: https://github.com/apache/airflow/pull/14152#discussion_r624273293



##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -474,6 +537,33 @@ The following tables lists the configurable parameters of 
the Airflow chart and
    * - ``cleanup.tolerations``
      - Toleration labels for pod assignment
      - ``1``
+   * - ``cleanup.serviceAccount.create``
+     - Create ServiceAccount for cleanup pods
+     - ``true``
+   * - ``cleanup.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``cleanup.serviceAccount.annotations``
+     - Annotations to add to cleanup cronjob kubernetes service account
+     - ``{}``
+   * - ``createUserJob.serviceAccount.create``
+     - Create ServiceAccount for create user job
+     - ``true``
+   * - ``createUserJob.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``createUserJob.serviceAccount.annotations``
+     - Annotations to add to createUserJob kubernetes service account
+     - ``{}``
+   * - ``migrateDatabaseJob.serviceAccount.create``
+     - Create ServiceAccount for migrate database job
+     - ``true``
+   * - ``migrateDatabaseJob.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``migrateDatabaseJob.serviceAccount.annotations``
+     - Annotations to add to migrateDatabaseJob kubernetes service account

Review comment:
       ```suggestion
        - Annotations to add to ``migrateDatabaseJob`` kubernetes service 
account
   ```

##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -474,6 +537,33 @@ The following tables lists the configurable parameters of 
the Airflow chart and
    * - ``cleanup.tolerations``
      - Toleration labels for pod assignment
      - ``1``
+   * - ``cleanup.serviceAccount.create``
+     - Create ServiceAccount for cleanup pods
+     - ``true``
+   * - ``cleanup.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``cleanup.serviceAccount.annotations``
+     - Annotations to add to cleanup cronjob kubernetes service account
+     - ``{}``
+   * - ``createUserJob.serviceAccount.create``
+     - Create ServiceAccount for create user job
+     - ``true``
+   * - ``createUserJob.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``createUserJob.serviceAccount.annotations``
+     - Annotations to add to createUserJob kubernetes service account

Review comment:
       ```suggestion
        - Annotations to add to ``createUserJob`` kubernetes service account
   ```

##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -420,6 +465,15 @@ The following tables lists the configurable parameters of 
the Airflow chart and
    * - ``pgbouncer.configSecretName``
      - Name of existing PgBouncer config secret
      - ``~``
+   * - ``pgbouncer.serviceAccount.create``
+     - Create ServiceAccount for pgbouncer
+     - ``true``
+   * - ``pgbouncer.serviceAccount.name``
+     - Name of ServiceAccount. If not set and create is true, a name is 
generated using the release name.
+     - ``~``
+   * - ``pgbouncer.serviceAccount.annotations``
+     - Annotations to add to pgbouncer kubernetes service account

Review comment:
       ```suggestion
        - Annotations to add to PgBouncer kubernetes service account
   ```

##########
File path: docs/helm-chart/parameters-ref.rst
##########
@@ -420,6 +465,15 @@ The following tables lists the configurable parameters of 
the Airflow chart and
    * - ``pgbouncer.configSecretName``
      - Name of existing PgBouncer config secret
      - ``~``
+   * - ``pgbouncer.serviceAccount.create``
+     - Create ServiceAccount for pgbouncer

Review comment:
       ```suggestion
        - Create ServiceAccount for PgBouncer
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to