ashb commented on a change in pull request #15599:
URL: https://github.com/apache/airflow/pull/15599#discussion_r625596212
##########
File path: airflow/models/renderedtifields.py
##########
@@ -57,9 +57,20 @@ def __init__(self, ti: TaskInstance, render_templates=True):
field: serialize_template_field(getattr(self.task, field)) for
field in self.task.template_fields
}
+ self._redact()
+
def __repr__(self):
return f"<{self.__class__.__name__}: {self.dag_id}.{self.task_id}
{self.execution_date}"
+ def _redact(self):
+ from airflow.utils.log.secrets_masker import redact
+
+ if self.k8s_pod_yaml:
+ self.k8s_pod_yaml = redact
Review comment:
No, this is not correct at all, which means it isn't covered by tests!
I'll expand this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
