BKronenbitter commented on pull request #15634:
URL: https://github.com/apache/airflow/pull/15634#issuecomment-831851094


   Thanks for your quick reaction. Let me address the individual fixes 
separately:
   
   - It am not aware of a practical way to test the sleep time in the main loop 
of the `_monitor_logging`. If you know a good way, of course I can do so.
   - I for sure can test the addition of the state for logging.
   - Testing the different log level does not make much sense, I would say. 
   - Testing the check for missing events is also tricky, since the exception 
is only logged and not raised further. If there is a good way to test, that no 
exception is logged within the main loop, of course I can do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to