ashb commented on a change in pull request #15638:
URL: https://github.com/apache/airflow/pull/15638#discussion_r625291823
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py
##########
@@ -169,7 +172,7 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) ->
Tuple[State, Optional[str]]
time.sleep(2)
return self._task_status(self.read_pod(pod)), result
- def parse_log_line(self, line: str) -> Tuple[str, str]:
+ def parse_log_line(self, line: str) -> Tuple[Optional[Union[Date, Time,
DateTime, Duration]], str]:
Review comment:
This type is overly broad - it should be Optional[Date time] shouldn't
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
