uranusjr commented on a change in pull request #15680:
URL: https://github.com/apache/airflow/pull/15680#discussion_r627077912
##########
File path: airflow/providers/amazon/aws/transfers/mongo_to_s3.py
##########
@@ -117,7 +117,6 @@ def execute(self, context) -> bool:
mongo_collection=self.mongo_collection,
query=cast(dict, self.mongo_query),
mongo_db=self.mongo_db,
- allowDiskUse=self.allow_disk_use,
Review comment:
> I think a note in the docstring saying that it requires MongoDB 4.4+
for `.find` and a link to the doc should be enough. It's neither sensible for
us to control the version of an external system nor that we can. IMO, the users
should know and control what MongoDB version they are using.
The issue is `aggregate(allowDiskUse=True)` does work prior to MongoDB 4.4,
and users running older MongoDB setups may still want to use that. If we always
also pass the argument to `find()`, they will have to create two `MongoHook`
instances, one with `allow_disk_use` (for `aggregate()`) and one without (for
`find()`), which doesn’t feel like good interface design to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
