alittlesliceoftom commented on issue #13888:
URL: https://github.com/apache/airflow/issues/13888#issuecomment-833490622


   Hi both, 
   Thanks so much for the response. Reading your point @jedcunningham , you're 
right and I don't get that log return. 
   
   I think I actually should have referenced 
https://github.com/apache/airflow/blob/31b956c6c22476d109c45c99d8a325c5c1e0fd45/airflow/kubernetes/pod_launcher.py#L156
   As this is what is called when get_logs = False. 
   
   I actually don't have the issue now as I now always get_logs=True. 
   
   That said I think there may be benefit in configurability on the sleep time 
in the condition that you are not getting logs, if only to keep the airflow 
logs a bit shorter. Typically I was using get_logs=False as a hack in response 
to #14259 . I now do a different hack so I can get the logs. 
   
   I think there is some benefit in making the 2s state update configurable , 
but it might be marginal. I suspect most users want to get logs in most 
situations. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to