ashb commented on a change in pull request #15674:
URL: https://github.com/apache/airflow/pull/15674#discussion_r628244162
##########
File path: airflow/ui/src/components/AppContainer/TimezoneDropdown.tsx
##########
@@ -44,9 +44,9 @@ const TimezoneDropdown: React.FC = () => {
const timezones = getTimeZones();
let currentTimezone;
- const options = timezones.map(({ name, currentTimeFormat }) => {
+ const options = timezones.map(({ name, currentTimeFormat, group }) => {
const label = `${currentTimeFormat.substring(0, 6)} ${name.replace(/_/g, '
')}`;
- if (name === timezone) currentTimezone = { label, value: name };
+ if (name === timezone || group.includes(timezone)) currentTimezone = {
label, value: name };
Review comment:
I'm not quite sure what this code is for then? If the only option is
what is in the drop down, then we can ignore groups can't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
