aneesh-joseph commented on a change in pull request #9973: URL: https://github.com/apache/airflow/pull/9973#discussion_r628834339
########## File path: airflow/migrations/versions/e9304a3141f0_make_xcom_pkey_columns_non_nullable.py ########## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""make xcom pkey columns non-nullable + +Revision ID: e9304a3141f0 +Revises: 83f031fd9f1c +Create Date: 2021-04-06 13:22:02.197726 + +""" +import sqlalchemy as sa +from alembic import op +from sqlalchemy.dialects import mssql, mysql + +from airflow.models.base import COLLATION_ARGS + +# revision identifiers, used by Alembic. +revision = 'e9304a3141f0' +down_revision = '83f031fd9f1c' +branch_labels = None +depends_on = None + + +def __use_date_time2(conn): + result = conn.execute( + """SELECT CASE WHEN CONVERT(VARCHAR(128), SERVERPROPERTY ('productversion')) + like '8%' THEN '2000' WHEN CONVERT(VARCHAR(128), SERVERPROPERTY ('productversion')) + like '9%' THEN '2005' ELSE '2005Plus' END AS MajorVersion""" + ).fetchone() + mssql_version = result[0] + return mssql_version not in ("2000", "2005") + + +def __get_timestamp(conn): + dialect_name = conn.dialect.name + if dialect_name == "mssql": + return mssql.DATETIME2(precision=6) if __use_date_time2(conn) else mssql.DATETIME + elif dialect_name != "mysql": + return sa.TIMESTAMP(timezone=True) + else: + return mysql.TIMESTAMP(fsp=6, timezone=True) + + +def upgrade(): Review comment: I have now clubbed all of the mssql specific ones into a single migration, but have left this one as is as it's not specific to mssql -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
