[
https://issues.apache.org/jira/browse/AIRFLOW-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Kef updated AIRFLOW-4292:
--------------------------------
Description:
There are currently a couple of issues open regarding SLAs.
eg:
* AIRFLOW-249
* AIRFLOW-1216
* AIRFLOW-2892
Admittedly, this function (`jobs.SchedulerJob.manage_slas`) could use some
improvements.
I open this issue, to start cleaning up and improving code quality (without
affecting functionalities - for now).
The exact problems I have identified:
* Improper data structures (eg lists that can either be replaced by generators
or sets)
* Smelly code (eg getting multiple times the current timestamp, redundant
filters)
* Code style, typos, 2-3 letter variable names, lack of comments
was:
There are currently a couple of issues open regarding SLAs.
eg:
* AIRFLOW-249
* AIRFLOW-1216
* AIRFLOW-2892
Admittedly, this function (`jobs.SchedulerJob.manage_slas`) could use some
improvements.
I open this issue, to start cleaning up and improving code quality (without
affecting functionalities).
The exact problems I have identified:
* Improper data structures (eg lists that can either be replaced by generators
or sets)
* Smelly code (eg getting multiple times the current timestamp, redundant
filters)
* Code style, typos, 2-3 letter variable names, lack of comments
> Cleanup and improve SLA code
> ----------------------------
>
> Key: AIRFLOW-4292
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4292
> Project: Apache Airflow
> Issue Type: Improvement
> Components: DAG, scheduler
> Reporter: Sergio Kef
> Assignee: Sergio Kef
> Priority: Major
>
> There are currently a couple of issues open regarding SLAs.
> eg:
> * AIRFLOW-249
> * AIRFLOW-1216
> * AIRFLOW-2892
> Admittedly, this function (`jobs.SchedulerJob.manage_slas`) could use some
> improvements.
> I open this issue, to start cleaning up and improving code quality (without
> affecting functionalities - for now).
> The exact problems I have identified:
> * Improper data structures (eg lists that can either be replaced by
> generators or sets)
> * Smelly code (eg getting multiple times the current timestamp, redundant
> filters)
> * Code style, typos, 2-3 letter variable names, lack of comments
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
