potiuk commented on pull request #15781: URL: https://github.com/apache/airflow/pull/15781#issuecomment-839038769
A little context here. 1) I used pytest-httpx fixture here which is very convenient way of mocking httpx, however it is pytest-fixture only - which means that we have to mix pytest and unittest type of tests. Howver I think this is justified (and I believe we've already agreed that it might make sense to have both kind of tests at least for a transition period. So this might be a good start. 2) I also might still take a look at slighly less-backwards-compatible change in HttpHook, however I think we will not avoid to also having to upgrade Airbyte, Livy and OpsgenieAlert providers - they all depend on HttpHook and I think we cannot make them backwrds-compatible. 3) If anyone thinks that makes sense I can split the PR, however getting rid of the requests as core dependency is common among all the changes. 4) I will have to add another change - add capability to add version dependencies between providers when they are generated. I planned to do it anyway and it was inevitable, but I want to do it as a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
