dstandish commented on a change in pull request #15266:
URL: https://github.com/apache/airflow/pull/15266#discussion_r631825481
##########
File path: airflow/providers/google/ads/hooks/ads.py
##########
@@ -69,22 +69,25 @@ class GoogleAdsHook(BaseHook):
:type gcp_conn_id: str
:param google_ads_conn_id: The connection ID with the details of Google
Ads config.yaml file.
:type google_ads_conn_id: str
+ :param api_version: The Google Ads API version to use.
+ :type api_version: str
:return: list of Google Ads Row object(s)
:rtype: list[GoogleAdsRow]
"""
+ default_version = "v5"
+
def __init__(
self,
+ api_version: str,
Review comment:
this needs to be optional
##########
File path: airflow/providers/google/ads/hooks/ads.py
##########
@@ -69,22 +69,25 @@ class GoogleAdsHook(BaseHook):
:type gcp_conn_id: str
:param google_ads_conn_id: The connection ID with the details of Google
Ads config.yaml file.
:type google_ads_conn_id: str
+ :param api_version: The Google Ads API version to use.
+ :type api_version: str
:return: list of Google Ads Row object(s)
:rtype: list[GoogleAdsRow]
"""
+ default_version = "v5"
Review comment:
while you're at it, i might suggest `default_api_version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
