feluelle commented on a change in pull request #15609:
URL: https://github.com/apache/airflow/pull/15609#discussion_r632349591
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -143,9 +143,9 @@ def parse_s3_url(s3url: str) -> Tuple[str, str]:
raise AirflowException(f'Please provide a bucket_name instead of
"{s3url}"')
bucket_name = parsed_url.netloc
- key = parsed_url.path.strip('/')
+ # key = parsed_url.path.strip('/')
- return bucket_name, key
+ return bucket_name, parsed_url.path
Review comment:
Please use the `key`. It is much more readable instead of
`parsed_url.path`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
