ashb commented on a change in pull request #15781:
URL: https://github.com/apache/airflow/pull/15781#discussion_r632452209
##########
File path: setup.py
##########
@@ -524,15 +543,15 @@ def get_sphinx_theme_version() -> str:
# Dict of all providers which are part of the Apache Airflow repository
together with their requirements
PROVIDERS_REQUIREMENTS: Dict[str, List[str]] = {
- 'airbyte': [],
+ 'airbyte': http_provider,
Review comment:
This is already handled by the cross-provider dep mechanism we have
isn't it?
https://github.com/apache/airflow/blob/bcfa0cbbfc941cae705a39cfbdd6330a5ba0578e/airflow/providers/dependencies.json#L2-L4
##########
File path: setup.py
##########
@@ -524,15 +543,15 @@ def get_sphinx_theme_version() -> str:
# Dict of all providers which are part of the Apache Airflow repository
together with their requirements
PROVIDERS_REQUIREMENTS: Dict[str, List[str]] = {
- 'airbyte': [],
+ 'airbyte': http_provider,
Review comment:
Oh, oh no, not correctly.
That' dependencies.json is only for _optional_ extras, so that would have
`apache-airflow-providers-airbyte[http]` -- but that doesn't make sense as it's
_required_.
Something to fix in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
