eladkal commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r633667909
########## File path: airflow/providers/asana/operators/asana_tasks.py ########## @@ -0,0 +1,170 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Dict, Optional + +from airflow.models import BaseOperator +from airflow.providers.asana.hooks.asana import AsanaHook + + +class AsanaCreateTaskOperator(BaseOperator): + """ + This operator can be used to create Asana tasks. For more information on + Asana optional task parameters, see https://developers.asana.com/docs/create-a-task + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:AsanaCreateTaskOperator` + + :param conn_id: The Asana connection to use. + :type conn_id: str + :param name: Name of the Asana task. + :type name: str + :param task_parameters: Any of the optional task creation parameters. + See https://developers.asana.com/docs/create-a-task for a complete list. + You must specify at least one of 'workspace', 'parent', or 'projects' + either here or in the connection. + :type task_parameters: dict + """ + + def __init__( + self, + *, + conn_id: str, + name: str, + task_parameters: Optional[dict] = None, + **kwargs, + ) -> None: + super().__init__(**kwargs) + + self.conn_id = conn_id + self.name = name + self.task_parameters = task_parameters + + def execute(self, context: Dict) -> str: + hook = AsanaHook(conn_id=self.conn_id) + response = hook.create_task(self.name, self.task_parameters) + self.log.info(response) + return response["gid"] + + +class AsanaUpdateTaskOperator(BaseOperator): + """ + This operator can be used to update Asana tasks. + For more information on Asana optional task parameters, see + https://developers.asana.com/docs/update-a-task + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:AsanaUpdateTaskOperator` + + :param conn_id: The Asana connection to use. + :type conn_id: str + :param asana_task_gid: Asana task ID to update + :type asana_task_gid: str + :param task_parameters: Any task parameters that should be updated. + See https://developers.asana.com/docs/update-a-task for a complete list. + :type task_update_parameters: dict + """ + + def __init__( + self, + *, + conn_id: str, + asana_task_gid: str, + task_parameters: dict, + **kwargs, + ) -> None: + super().__init__(**kwargs) + + self.conn_id = conn_id + self.asana_task_gid = asana_task_gid + self.task_parameters = task_parameters + + def execute(self, context: Dict) -> None: + hook = AsanaHook(conn_id=self.conn_id) + response = hook.update_task(self.asana_task_gid, self.task_parameters) + self.log.info(response) + + +class AsanaDeleteTaskOperator(BaseOperator): + """ + This operator can be used to delete Asana tasks. + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:AsanaDeleteTaskOperator` + + :param conn_id: The Asana connection to use. + :type conn_id: str + :param asana_task_gid: Asana Task ID to delete. + :type asana_task_gid: str + """ + + def __init__( + self, + *, + conn_id: str, + asana_task_gid: str, + **kwargs, + ) -> None: + super().__init__(**kwargs) + + self.conn_id = conn_id + self.asana_task_gid = asana_task_gid + + def execute(self, context: Dict) -> None: + hook = AsanaHook(conn_id=self.conn_id) Review comment: In the connection you are able to set `workspace` and `project` but the operators doesn't seem to allow to overwrite the default. Does this means that we need to define connection per workspace,project? Should we allow overwrite in the operator level? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
