ashb commented on a change in pull request #15795:
URL: https://github.com/apache/airflow/pull/15795#discussion_r636309175
##########
File path: airflow/models/connection.py
##########
@@ -348,6 +348,25 @@ def debug_info(self):
self.extra_dejson,
)
+ def test_connection(self):
+ """Calls out get_hook method and executes test_connection method on
that."""
+ status, message = False, ''
+ try:
+ hook = self.get_hook()
+ if hook and getattr(hook, 'test_connection', False):
+ status, message = hook.test_connection()
+ else:
+ message = (
+ f"Hook {hook.__class__.__name__} doesn't implement or
inherit test_connection method"
Review comment:
This could also be no hook class found.
##########
File path: airflow/www/static/js/connection_form.js
##########
@@ -140,6 +140,55 @@ $(document).ready(function () {
}
}
+ $.fn.serializeObject = function () {
+ const o = {};
+ const a = this.serializeArray();
+ $.each(a, function () {
+ if (this.name === 'csrf_token') {
+ // dont send csrf token
+ } else if (this.name === 'conn_id') {
+ o.connection_id = this.value;
+ } else if (this.value !== '') {
+ o[this.name] = this.value;
+ }
+ });
+ return o;
+ };
Review comment:
I think this functionality is built in to jQuery.
/cc @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
