ashb commented on a change in pull request #15795:
URL: https://github.com/apache/airflow/pull/15795#discussion_r636863418
##########
File path: airflow/models/connection.py
##########
@@ -348,6 +348,25 @@ def debug_info(self):
self.extra_dejson,
)
+ def test_connection(self):
+ """Calls out get_hook method and executes test_connection method on
that."""
+ status, message = False, ''
+ try:
+ hook = self.get_hook()
+ if hook and getattr(hook, 'test_connection', False):
+ status, message = hook.test_connection()
+ else:
+ message = (
+ f"Hook {hook.__class__.__name__} doesn't implement or
inherit test_connection method"
Review comment:
Which is a bit confusing to a user if it happens -- I think we should
have a different message for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
