andrewgodwin commented on a change in pull request #15389:
URL: https://github.com/apache/airflow/pull/15389#discussion_r638961397
##########
File path: airflow/models/dag.py
##########
@@ -1177,8 +1179,10 @@ def clear(
:type dry_run: bool
:param session: The sqlalchemy session to use
:type session: sqlalchemy.orm.session.Session
- :param get_tis: Return the sqlalchemy query for finding the
TaskInstance without clearing the tasks
- :type get_tis: bool
+ :param get_ti_keys: Return the sqlalchemy query for TaskInstance PKs
without clearing the tasks
+ :type get_ti_keys: bool
+ :param get_ti_instances: Return the sqlalchemy query for TaskInstances
without clearing the tasks
+ :type get_ti_instances: bool
Review comment:
Unfortunately I can't do that without duplicating all the logic at the
end of `clear()` - it's a bit of a mess of a function, and some parts of its
logic depend on having instances at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
