yoshichulo commented on a change in pull request #16003:
URL: https://github.com/apache/airflow/pull/16003#discussion_r639334252
##########
File path: airflow/providers/discord/hooks/discord_webhook.py
##########
@@ -101,7 +101,7 @@ def _get_webhook_endpoint(self, http_conn_id:
Optional[str], webhook_endpoint: O
'Expected Discord webhook endpoint in the form of
"webhooks/{webhook.id}/{webhook.token}".'
)
- return endpoint
+ return f'https://discord.com/api/{endpoint}'
Review comment:
Hmmm, it' seems like if you do so, with the `http_con_id` is working
fine. Then the problem is I guess only with the `webhook_endpoint`, which is
missing the host.
If that's so, then the more logic thing to do would be formatting the
endpoint on the first if to be
`https://discord.com/api/webhooks/{webhook.id}/{webhook.token}` instead of in
the return, since both `http_conn_id` and `webhook_endpoint` are optional
parametters and shall be able to work independently of each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
