potiuk commented on a change in pull request #16002:
URL: https://github.com/apache/airflow/pull/16002#discussion_r639843974
##########
File path: airflow/providers/microsoft/azure/log/wasb_task_handler.py
##########
@@ -176,19 +178,18 @@ def wasb_write(self, log: str, remote_log_location: str,
append: bool = True) ->
:type log: str
:param remote_log_location: the log's location in remote storage
:type remote_log_location: str (path)
- :param append: if False, any existing log file is overwritten. If True,
+ :param append: if False, any existing log file is overwritten with the
new log. If True,
Review comment:
What happens when:
1) log file exists
2) Append = false
3) Overwrite = false
I think it's not really obvious and help is not really helpful in this
situation. Could you please clarify that in the description of the parameters ?
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
