grassten edited a comment on issue #16068: URL: https://github.com/apache/airflow/issues/16068#issuecomment-848357809
@potiuk I'm wondering if we should split the passed sql param and then parameterize the resulting queries, or stop splitting the string altogether (splitting was implemented recently in #15533). To split the string I think we could use `from snowflake.connector.util_text import split_statements`; that's what's used by execute_string in the Snowflake connector. (I have that in a PR in my fork [here](https://github.com/grassten/airflow/pull/1)) That being said, I don't think parameterizing a list of queries (after splitting) with a single set of params is valid. I think we should put the passed sql into a single item list & pass it through the existing code; this seems more in line w/ what you would expect to happen. cc @mobuchowski @eladkal I see you guys on that PR, what do you think? Edit: I've submitted the PR to use split_statements; I think this implementation makes strings w/ multiple statements behave similarly to lists of sql in its parameter handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
