casra-developers commented on a change in pull request #16110:
URL: https://github.com/apache/airflow/pull/16110#discussion_r640677988
##########
File path: airflow/utils/process_utils.py
##########
@@ -20,14 +20,20 @@
import errno
import logging
import os
-import pty
import select
import shlex
import signal
import subprocess
import sys
-import termios
-import tty
+from airflow.utils.platform_utils import is_windows
+
+if is_windows():
+ from airflow.windows_extensions import termios, tty, pty
+else:
+ import pty
+ import termios
+ import tty
Review comment:
I will do that. If I understand you correctly you basically do import
distinction in one file and than just import from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
