natanweinberger commented on a change in pull request #15425:
URL: https://github.com/apache/airflow/pull/15425#discussion_r640682833



##########
File path: airflow/cli/commands/connection_command.py
##########
@@ -28,9 +28,9 @@
 from airflow.exceptions import AirflowNotFoundException
 from airflow.hooks.base import BaseHook
 from airflow.models import Connection
-from airflow.secrets.local_filesystem import _create_connection, 
load_connections_dict
 from airflow.utils import cli as cli_utils, yaml
 from airflow.utils.cli import suppress_logs_and_warning
+from airflow.utils.parse import parse_file

Review comment:
       Got rid of utils/parse.py and left the functionality where it was in 
`secrets/local_filesystem.py`.

##########
File path: airflow/cli/commands/connection_command.py
##########
@@ -28,9 +28,9 @@
 from airflow.exceptions import AirflowNotFoundException
 from airflow.hooks.base import BaseHook
 from airflow.models import Connection
-from airflow.secrets.local_filesystem import _create_connection, 
load_connections_dict
 from airflow.utils import cli as cli_utils, yaml
 from airflow.utils.cli import suppress_logs_and_warning
+from airflow.utils.parse import parse_file

Review comment:
       Got rid of `utils/parse.py` and left the functionality where it was in 
`secrets/local_filesystem.py`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to