natanweinberger commented on pull request #15425: URL: https://github.com/apache/airflow/pull/15425#issuecomment-849688714
@ashb Thanks for the feedback. As we discussed, simplified this PR a lot by reverting some of the changes and focusing on the bugfix. Here's a summary of the changes: - the `Connection` constructor handles non-strings in the `extra` kwarg connections import functionality - the connections import function uses the existing file parsing logic and passes the loaded dicts to `Connection.__init__()` - fixed a test to catch the issue that slipped through originally (root cause is summarized in the first comment in this PR) Much simpler! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
