malthe commented on a change in pull request #16115:
URL: https://github.com/apache/airflow/pull/16115#discussion_r640689998
##########
File path: airflow/providers/samba/hooks/samba.py
##########
@@ -36,12 +36,26 @@ def __init__(self, samba_conn_id: str = default_conn_name)
-> None:
self.conn = self.get_connection(samba_conn_id)
def get_conn(self) -> SambaClient:
+ """
+ Return a samba client object.
+
+ You can provide optional parameters in the extra fields of
+ your connection.
+
+ :param logdir: Base directory name for log/debug files.
+ :param kerberos: Try to authenticate with kerberos.
+ :param workgroup: Set the SMB domain of the username.
+ :param netbios_name:
+ This option allows you to override the NetBIOS name that
+ Samba uses for itself.
+ """
samba = SambaClient(
server=self.conn.host,
share=self.conn.schema,
username=self.conn.login,
ip=self.conn.host,
password=self.conn.password,
+ **self.conn.extra_dejson,
Review comment:
@uranusjr fixed in 0c8cca7 – the list is inexhaustive (mentioned now)
and I have reformatted as definition list.
The `:param` stuff was token from the Oracle hook, but I guess that is a bad
example :-)
By the way, I have since realized that the underlying Python library that
supports `SambaHook` is basically abandonware and not particularly useful – it
breaks quite a few expectations if you look at the actual `smbclient`
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
