natanweinberger edited a comment on pull request #15425:
URL: https://github.com/apache/airflow/pull/15425#issuecomment-850441089


   @ashb I've switched back to using `load_connections_dict`, which handles the 
logic for loading the connection values into the Connection model. So, the 
import function just loops through the dicts and and adds those to the session 
and commits them.
   
   This should be very similar now to the first iteration of this PR, just a 
bugfix for properly treating the `load_connections_dict` result as a 
`Connection` instance instead of a dict (and updating the tests).
   
   (by the way, taking a closer look at `connections export` function - it will 
never export a field `extra_dejson`, so it might be ok to let the import 
function assume it will never be present. It can only be present if someone 
manually edits the export to include it)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to