jedcunningham commented on a change in pull request #16117:
URL: https://github.com/apache/airflow/pull/16117#discussion_r641596016



##########
File path: chart/values.yaml
##########
@@ -846,8 +846,18 @@ elasticsearch:
   #   port: ~
   connection: {}
 
+# All container ports used by chart, hard code here.
+_ports:

Review comment:
       Yeah, I agree. Maybe `containerPorts`?
   
   It might also make sense to only expose ports in values.yaml that can 
actually be changed (e.g. airflowUI, flowerUI and workerLogs), and actively 
prevent others from being changed if we can (e.g. pgbouncer).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to