mik-laj commented on a change in pull request #16170: URL: https://github.com/apache/airflow/pull/16170#discussion_r642899880
########## File path: docs/helm-chart/quick-start.rst ########## @@ -65,8 +65,17 @@ Run ``kubectl port-forward svc/airflow-webserver 8080:8080 -n airflow`` to port-forward the Airflow UI to http://localhost:8080/ to confirm Airflow is working. -Build a Docker image from your DAGs ------------------------------------ +Extending Airflow Image Review comment: I have mixed feelings about this. This is a quick start guide for Helm Chart, and I think we should be focusing on that. For the same reason, we do not describe image building in the [Docker-compose guide](http://airflow.apache.org/docs/apache-airflow/stable/start/docker.html). Now over 60% of the content on this guide is not about Helm Chart but about the image. Helm Chart for Gitlab has a separate guide [for the custom image/images](https://docs.gitlab.com/charts/advanced/custom-images/index.html). What do you think about it? They also have [a quick start guide](https://docs.gitlab.com/charts/quickstart/index.html). Helm Chart for JupytterHub also have comprehensive documentation with [guide for custom image](https://zero-to-jupyterhub.readthedocs.io/en/latest/jupyterhub/customizing/user-environment.html#choose-and-use-an-existing-docker-image) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
