turbaszek commented on a change in pull request #16268:
URL: https://github.com/apache/airflow/pull/16268#discussion_r645739512
##########
File path: airflow/models/dagrun.py
##########
@@ -737,13 +737,13 @@ def schedule_tis(self, schedulable_tis: Iterable[TI],
session: Session = None) -
Each element of ``schedulable_tis`` should have it's ``task``
attribute already set.
- Any DummyOperator without callbacks is instead set straight to the
success state.
+ Any NoOpOperatorwithout callbacks is instead set straight to the
success state.
Review comment:
```suggestion
Any NoOpOperator without callbacks is instead set straight to the
success state.
```
##########
File path: airflow/models/dagrun.py
##########
@@ -737,13 +737,13 @@ def schedule_tis(self, schedulable_tis: Iterable[TI],
session: Session = None) -
Each element of ``schedulable_tis`` should have it's ``task``
attribute already set.
- Any DummyOperator without callbacks is instead set straight to the
success state.
+ Any NoOpOperatorwithout callbacks is instead set straight to the
success state.
All the TIs should belong to this DagRun, but this code is in the
hot-path, this is not checked -- it
is the caller's responsibility to call this function only with TIs
from a single dag run.
"""
# Get list of TI IDs that do not need to executed, these are
- # tasks using DummyOperator and without on_execute_callback /
on_success_callback
+ # tasks using NoOpOperatorand without on_execute_callback /
on_success_callback
Review comment:
```suggestion
# tasks using NoOpOperator and without on_execute_callback /
on_success_callback
```
##########
File path: airflow/models/dagrun.py
##########
@@ -769,7 +769,7 @@ def schedule_tis(self, schedulable_tis: Iterable[TI],
session: Session = None) -
.update({TI.state: State.SCHEDULED}, synchronize_session=False)
)
- # Tasks using DummyOperator should not be executed, mark them as
success
+ # Tasks using NoOpOperatorshould not be executed, mark them as success
Review comment:
```suggestion
# Tasks using NoOpOperator should not be executed, mark them as
success
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
