olivermeyer edited a comment on issue #16299:
URL: https://github.com/apache/airflow/issues/16299#issuecomment-855888329


   > > I believe (and this is somewhat opinionated) that the 
SageMakerTrainingOperator should not be responsible for renaming jobs
   > 
   > The reason for renaming is explained in #7598
   > Do you have alternative solution?
   
   I guess the solution depends on one's opinion: as I mentioned above I 
believe the operator should not rename the training job it is creating, and 
making sure the name being used it unique should be done elsewhere (and is the 
responsibility of whoever is using the operator). Exactly how they ensure this 
uniqueness (and listing existing jobs is only one solution here) is up to them. 
If that's out of the question, then perhaps a switch allowing the user to 
decide whether to check for uniqueness or not would do.
   
   Perhaps the author of the original PR (@BasPH) has an opinion? Did you deal 
with a situation where the AWS account used by SageMaker had hundreds of 
existing jobs and the listing operation was throttled?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to