uranusjr commented on pull request #16311:
URL: https://github.com/apache/airflow/pull/16311#issuecomment-856854967
Why is `session.connection().dialect` being called over and over? I’d assume
it’s better to do something like
```python
dialect = session.connection().dialect
if dialect.name == "postgresql":
...
elif dialect.name == "mysql" and dialect.server_version_info >= (5, 6):
...
```
which is much more readable. Or is there a side-effect stuff that I’m not
aware of making this not viable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
