ephraimbuddy commented on a change in pull request #16318:
URL: https://github.com/apache/airflow/pull/16318#discussion_r648094815
##########
File path: tests/api_connexion/endpoints/test_dag_endpoint.py
##########
@@ -387,6 +396,7 @@ def test_should_raise_404_when_dag_is_not_found(self):
class TestGetDags(TestDagEndpoint):
def test_should_respond_200(self):
self._create_dag_models(2)
+ self._create_deactivated_dag()
Review comment:
I know but how are we sure that an inactive dag exists here? Do we have
a test for the new method you created? I think that querying DagModel and
asserting that it has 3 dags(both active and inactive) at this point will help
to know that the method you created works fine. If there's an alteration in the
method in the future to work another way, it'll be noticed. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
