msumit commented on a change in pull request #16233:
URL: https://github.com/apache/airflow/pull/16233#discussion_r648876039
##########
File path: airflow/www/templates/airflow/confirm.html
##########
@@ -28,11 +28,17 @@ <h2>Wait a minute.</h2>
<pre><code>{{ details }}</code></pre>
{% endif %}
</div>
- <form method="POST">
+ {% if endpoint %}
+ <form method="POST" action="/{{ endpoint }}">
+ {% else %}
+ <form method="POST">
+ {% endif %}
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}"/>
<input type="hidden" name="confirmed" value="true">
- {% for name,val in request.form.items() if name != "csrf_token" %}
- <input type="hidden" name="{{ name }}" value="{{ val }}">
+ {% for args_gen_dict in (request.args.items(), request.form.items()) %}
Review comment:
@ashb `request.args != request.form`, so looping over both of them. Is
there any other better way you can think of?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
