lidalei commented on a change in pull request #16338:
URL: https://github.com/apache/airflow/pull/16338#discussion_r649058789
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -135,8 +135,13 @@ def get_conn(self) -> pysftp.Connection:
}
if self.password and self.password.strip():
conn_params['password'] = self.password
- if self.key_file:
+
+ # Try to use the paramiko key from the SSH hook
Review comment:
suggestion: Better to remove line 107 and 108
```
if 'private_key' in extra_options:
self.key_file = extra_options.get('private_key')
```
and update doc for SFTPHook.
Note pysftp only supports RSA and DSS keys while SSHHook also supports ECDSA
and Ed25519 keys. Worth to note in doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
