[
https://issues.apache.org/jira/browse/AIRFLOW-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818121#comment-16818121
]
ASF subversion and git services commented on AIRFLOW-2836:
----------------------------------------------------------
Commit cfa4b21851a68995805333b1b34e881fea35d619 in airflow's branch
refs/heads/v1-10-test from Xiaodong
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=cfa4b21 ]
[AIRFLOW-2836] Minor improvement-contrib.sensors.FileSensor (#3674)
- The default value of fs_conn_id was not proper.
- Added a new test in which we try to ignore setting
fs_conn_id explicitly.
- a minor change on how a path is concatenated
> Minor improvement of contrib.sensors.FileSensor
> -----------------------------------------------
>
> Key: AIRFLOW-2836
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2836
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> h4. *Background*
> The default *fs_conn_id* in contrib.sensors.FileSensor is '_*fs_default2*_'.
> However, when we initiate the database
> (https://github.com/apache/incubator-airflow/blob/master/airflow/utils/db.py#L88),
> there isn't such an entry. It doesn't exist anywhere else.
> h4. *Issue*
> The purpose of _contrib.sensors.FileSensor_ is mainly for checking local file
> system (of course can also be used for NAS). Then the path ("/") from default
> connection 'fs_default' would suffice.
> However, given the default value for *fs_conn_id* in
> contrib.sensors.FileSensor is "fs_default2" (a value doesn't exist), it will
> make the situation much more complex.
> When users intend to check local file system only, they should be able to
> leave *fs_conn_id* default directly, instead of going setting up another
> connection separately.
> h4. Proposal
> Change default value for *fs_conn_id* in contrib.sensors.FileSensor from
> "fs_default2" to "fs_default" (actually in the related test, the *fs_conn_id*
> are all specified to be "fs_default").
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
