sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860784508
We will want to keep the Airflow tag standardized, so I would not want to include the version. Ultimately, this is what we need the code to look like when we call to make the connection: con = snowflake.connector.connect ( user='XXXX', password='XXXX', account='XXXX', application='Airflow', ... ) If we want to remove the user-defined part of it. It should just be one line of code. On Mon, Jun 14, 2021 at 10:30 AM Jarek Potiuk ***@***.***> wrote: > Go discussion on whether this should be a user-defined parameter that > could be over-written. The idea was for managed airflow providers > (Astronomer, AWS), they could override this parameter for their > installations of this repo. I guess they could override an non user-defined > parameter as well. Any thoughts? I can talk to Ry over at Astronomer on > this. > > I think it would be great to be able to override it without changing > neither DAGs, nor provider code. but adding version of Airflow might be a > good idea indeed. @sfc-gh-madkins <https://github.com/sfc-gh-madkins> is > this label somehow standardized on Snowflake side, or is it ok to add + > version.version as it is in case of Google Providers? > > Ultimately maybe this will do?: > > os.enviroment.get('_SNOWFLAKE_AIRFLOW_LABEL', "AIRFLOW" + version.version) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/airflow/pull/16420#issuecomment-860778954>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ATSRCU6PUBOIU4F2Y6NBZZTTSYOBXANCNFSM46TNNUEQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
