jedcunningham commented on a change in pull request #15490:
URL: https://github.com/apache/airflow/pull/15490#discussion_r651265183
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -545,17 +544,17 @@ def monitor_launched_pod(self, launcher, pod) ->
Tuple[State, Optional[str]]:
:return:
"""
try:
- (final_state, result) = launcher.monitor_pod(pod,
get_logs=self.get_logs)
+ (final_state, pod_info, result) = launcher.monitor_pod(pod,
get_logs=self.get_logs)
finally:
if self.is_delete_operator_pod:
launcher.delete_pod(pod)
if final_state != State.SUCCESS:
if self.log_events_on_failure:
- for event in launcher.read_pod_events(pod).items:
+ for event in pod_info.items:
Review comment:
The pod events are still available after deleting the pod. We can't use
`read_namespaced_pod`, but `read_pod_events` should still work. We also won't
get `pod_info` back here in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
